Make VoiceOver correctly read the "new" label in the menu
Minor
提交哈希:
d8dc9460ac01bb3ff6fca7afc1527a7dc8326668
提交时间: 2025-09-11 16:49:44+00:00
影响等级: Minor
生成工具: webview2-upstream-sentry
上游审核链接:
查看上游审核 🔗
📋 摘要
This submission is primarily aimed at improving accessibility features, ensuring that VoiceOver can correctly read the "new" label marked as a new feature in menu items. The main changes include: 1) Renaming the function from NewTagImage to NewBadgeImage for more accurate naming; 2) Updating the corresponding function calls in MenuControllerCocoaDelegateImpl; 3) Possibly adding relevant accessibility attributes to support VoiceOver reading functionality. All these changes are concentrated in the components/remote_cocoa/app_shim/menu_controller_cocoa_delegate_impl.mm file.
🎯 影响分析
This change has minimal impact on WebView2Mac. The modification mainly involves the display of new feature labels in the menu controller and accessibility improvements. Since WebView2Mac uses remote_cocoa to handle UI elements on macOS, including menu-related functionality, this change may slightly affect the accessibility experience of menu items in WebView2Mac applications. Specifically: 1) If a WebView2Mac application uses menu items marked as new features, VoiceOver can now better read these labels; 2) Function renaming does not affect existing functionality and only makes the code clearer; 3) There is no direct impact on the core functions of WebView2Mac (such as web page rendering, window management, etc.). Overall, this is a positive improvement that enhances the accessibility user experience.
受影响的类:
MenuControllerCocoaDelegateImpl
remote_cocoa::mojom::MenuControllerParams