Pre-format files affected by removing [Native] from network_param.mojom
Minor
Commit Hash:
d4d257b3186bca0db8260fd5fd0303ca8b5a707d
Commit Time: 2026-04-08 21:15:14
Impact Level: Minor
Generated By: webview2-upstream-sentry
Upstream Review:
View Upstream Review 🔗
📋 Summary
This commit is a pure formatting change in preparation for removing the [Native] attribute from network_param.mojom. For the remote_cocoa part, it reformats components/remote_cocoa/common/native_widget_ns_window.mojom:
1. Reordered import statements alphabetically (menu.mojom moved before select_file_dialog.mojom).
2. Added trailing comma to the last value kMiniaturizeWindow in WindowVisibilityState enum.
3. Reformatted parameter lists of multiple interface methods (CreateContentView, SetInitialBounds, SetSize, SetSizeAndCenter, SetAspectRatio, EnableImmersiveFullscreen, BeginFileDrag) to a more compact format.
4. Added a blank line between AcquireCapture and ReleaseCapture.
All changes are whitespace and formatting adjustments with no impact on functional logic or interface definitions.
1. Reordered import statements alphabetically (menu.mojom moved before select_file_dialog.mojom).
2. Added trailing comma to the last value kMiniaturizeWindow in WindowVisibilityState enum.
3. Reformatted parameter lists of multiple interface methods (CreateContentView, SetInitialBounds, SetSize, SetSizeAndCenter, SetAspectRatio, EnableImmersiveFullscreen, BeginFileDrag) to a more compact format.
4. Added a blank line between AcquireCapture and ReleaseCapture.
All changes are whitespace and formatting adjustments with no impact on functional logic or interface definitions.
🎯 Impact Analysis
This change has virtually no impact on WebView2Mac. Key analysis:
1. **Pure formatting change**: All modifications are whitespace, trailing comma, and parameter indentation adjustments that do not alter any mojom interface definitions, method signatures, or enum values. The generated C++ code is completely unaffected.
2. **native_widget_ns_window.mojom is a core interface**: While the modified file is the core mojom interface definition for Remote Cocoa cross-process communication, since only formatting is changed, there is no impact on WebView2Mac compilation or runtime.
3. **Minor merge conflicts possible upon integration**: If Edge repo has custom modifications to this mojom file (such as added methods or parameter changes), the formatting changes may produce textual conflicts during git merge, but they would be trivial to resolve.
1. **Pure formatting change**: All modifications are whitespace, trailing comma, and parameter indentation adjustments that do not alter any mojom interface definitions, method signatures, or enum values. The generated C++ code is completely unaffected.
2. **native_widget_ns_window.mojom is a core interface**: While the modified file is the core mojom interface definition for Remote Cocoa cross-process communication, since only formatting is changed, there is no impact on WebView2Mac compilation or runtime.
3. **Minor merge conflicts possible upon integration**: If Edge repo has custom modifications to this mojom file (such as added methods or parameter changes), the formatting changes may produce textual conflicts during git merge, but they would be trivial to resolve.
Impacted Classes:
remote_cocoa::mojom::NativeWidgetNSWindow