Add IWYU header reference for NOTIMPLEMENTED() macro in //components
Minor
Commit Hash:
bc5784f03d2120209e60bc1c2ba266ecccb63dfb
Commit Time: 2025-06-19 19:35:05+00:00
Impact Level: Minor
Generated By: webview2-upstream-sentry
Upstream Review:
View Upstream Review 🔗
📋 Summary
This submission is an IWYU (Include What You Use) code cleanup, primarily adding the "base/notimplemented.h" header file reference to files using the NOTIMPLEMENTED() macro under the //components directory, and removing the "base/notreached.h" reference from files that do not use the NOTREACHED() macro. A total of 100 files were modified, including remote_cocoa-related files such as bridged_content_view.mm. This change only adjusts header file inclusions and does not involve any modifications to business logic or functional implementation.
🎯 Impact Analysis
The impact of this change on WebView2Mac is extremely limited. The specific analysis is as follows:
1. **Header File Inclusion Adjustment**: Only the #include "base/notreached.h" in the bridged_content_view.mm file is replaced with #include "base/notimplemented.h", because the NOTIMPLEMENTED() macro is used in this file instead of the NOTREACHED() macro.
2. **No Functional Impact**: Both NOTIMPLEMENTED() and NOTREACHED() are macros used for debugging and development; NOTIMPLEMENTED() is used to mark unimplemented functionality, while NOTREACHED() is used to mark code paths that should not be executed. This adjustment merely ensures the correct header file is included and does not change any runtime behavior.
3. **WebView2Mac Compatibility**: bridged_content_view.mm is the core view component of Remote Cocoa, responsible for handling events, input, drag-and-drop, and other functions. The header file adjustment does not affect the implementation of these core functions, so there is no negative impact on WebView2Mac's embedded web content, user interaction handling, or other features.
4. **Improved Compilation Robustness**: Ensuring the correct header file is included helps improve compilation robustness and avoids potential compilation errors.
1. **Header File Inclusion Adjustment**: Only the #include "base/notreached.h" in the bridged_content_view.mm file is replaced with #include "base/notimplemented.h", because the NOTIMPLEMENTED() macro is used in this file instead of the NOTREACHED() macro.
2. **No Functional Impact**: Both NOTIMPLEMENTED() and NOTREACHED() are macros used for debugging and development; NOTIMPLEMENTED() is used to mark unimplemented functionality, while NOTREACHED() is used to mark code paths that should not be executed. This adjustment merely ensures the correct header file is included and does not change any runtime behavior.
3. **WebView2Mac Compatibility**: bridged_content_view.mm is the core view component of Remote Cocoa, responsible for handling events, input, drag-and-drop, and other functions. The header file adjustment does not affect the implementation of these core functions, so there is no negative impact on WebView2Mac's embedded web content, user interaction handling, or other features.
4. **Improved Compilation Robustness**: Ensuring the correct header file is included helps improve compilation robustness and avoids potential compilation errors.
Impacted Classes:
BridgedContentView