Remove Accidentally Committed Logging Code
Minor
Commit Hash:
9ac4d00a67e08cd1f776799045d796552000f279
Commit Time: 2025-08-21 17:09:12+00:00
Impact Level: Minor
Generated By: webview2-upstream-sentry
Upstream Review:
View Upstream Review 🔗
📋 Summary
This submission removes a line of debug log code that was accidentally committed in the
components/remote_cocoa/app_shim/select_file_dialog_bridge.mm file. Specifically, it removes the NSLog(@"dropping %@", path); statement at line 617, which is located in the logic handling file packages in the file selection dialog and was used to print debug information when the file does not exist or is a directory but not a package. This change is purely code cleanup with no functional modifications.
🎯 Impact Analysis
Since this change only removes a single debug log statement, it has no impact on the functionality of WebView2Mac. The removed NSLog statement was located in the file validation logic of the SelectFileDialogBridge class, which is a core part of the remote_cocoa component. WebView2Mac implements file selection dialog functionality by inheriting and using this class. Although WebView2Mac depends on SelectFileDialogBridge, removing the debug log does not alter any business logic, file selection behavior, or user interface. There may be a slight positive impact on performance due to the elimination of unnecessary log output operations.
Impacted Classes:
SelectFileDialogBridge