Migrate BASE_FEATURE macro to two-parameter version

Minor

Commit Hash: 67735866800aa838628039f951a3095d0602f03c

Commit Time: 2025-09-16 05:15:54+00:00

Impact Level: Minor

Generated By: webview2-upstream-sentry

Upstream Review: View Upstream Review 🔗

📋 Summary

This submission is an automated refactoring that migrates the BASE_FEATURE macro throughout the //components directory from the three-parameter version to the two-parameter version, ensuring that the C++ identifier matches the string feature name. This guarantees that the C++ identifier and the string feature name are always consistent, reducing potential errors. In the changes related to remote_cocoa, the features kImmersiveFullscreenSpaceSwitchMitigation and kImmersiveFullscreenOverlayWindowDebug are migrated from the three-parameter form to the two-parameter form, removing the explicit string name parameter.

🎯 Impact Analysis

As this is a purely refactoring change, it only modifies the invocation method of the BASE_FEATURE macro without altering any functional logic. The new version of the macro will automatically use the C++ identifier as the string feature name, ensuring name consistency. For WebView2Mac, this does not affect any existing functionality: 1) The behavior of Remote Cocoa’s immersive fullscreen feature (kImmersiveFullscreenSpaceSwitchMitigation) and debugging feature (kImmersiveFullscreenOverlayWindowDebug) remains unchanged; 2) The default enabled/disabled state of the features remains unchanged; 3) WebView2Mac’s dependencies on these Remote Cocoa features are not affected; 4) There is no impact on NSWindow bridging, window management, or other core Remote Cocoa functionalities. This change is solely for code maintainability improvement and has no functional impact.

Impacted Classes:

remote_cocoa::features::kImmersiveFullscreenSpaceSwitchMitigation remote_cocoa::features::kImmersiveFullscreenOverlayWindowDebug