Remove debug logs from override_ns_next_step_frame_hit_test.mm
Minor
Commit Hash:
629f92e0d81ad5d4498daf085c8c676e428d8034
Commit Time: 2025-09-01 19:15:29+00:00
Impact Level: Minor
Generated By: webview2-upstream-sentry
Upstream Review:
View Upstream Review 🔗
📋 Summary
This submission removes debugging-related code from the components/remote_cocoa/app_shim/override_ns_next_step_frame_hit_test.mm file. Specific changes include: deleting references to the base/debug/stack_trace.h and base/logging.h header files, removing related TODO comments and debugging log code. This file implements a fix for the NSNextStepFrame hit test override mechanism for handling right mouse button events in macOS fullscreen mode. This change is purely code cleanup, removing debugging code that is no longer needed.
🎯 Impact Analysis
Since this change only removes debug log code and related header file references without altering any core functional logic, the impact on WebView2Mac is extremely limited. The override_ns_next_step_frame_hit_test.mm file handles mouse event hit testing in macOS fullscreen mode, which may indirectly affect WebView2Mac’s mouse event handling in fullscreen mode. However, as only debug code is being removed and no core logic is modified, it is expected that there will be no impact on the actual functional performance of WebView2Mac. The only potential impact is that if WebView2Mac relies on these log outputs when debugging mouse event-related issues, its debugging capability may be slightly reduced.
Impacted Classes:
NSNextStepFrame (系统类的方法重载)