Rename native_widget_types.h to native_window_types.h (Part 9 - components directory)
Minor
Commit Hash:
4e2f3f333b212df1894c268e2dc1e5c0ce67cc77
Commit Time: 2025-08-27 23:46:15+00:00
Impact Level: Minor
Generated By: webview2-upstream-sentry
Upstream Review:
View Upstream Review 🔗
📋 Summary
This submission is the ninth part of a large-scale renaming operation, mainly replacing all references to the "ui/gfx/native_widget_types.h" header file with "ui/gfx/native_window_types.h" under the components directory. This change affects 53 files, including multiple remote_cocoa-related files. Among the remote_cocoa-related files, the main ones involved are immersive_mode_controller_cocoa.mm, native_widget_mac_nswindow.mm, native_widget_ns_window_bridge.mm, application_host.h, and window.h. This is a purely header file renaming, without any changes to actual business logic or data type definitions.
🎯 Impact Analysis
Since this commit is merely a renaming of the header file, without any changes to actual functional code, data structures, or interface definitions, there is no functional impact on WebView2Mac. native_widget_types.h and native_window_types.h contain identical content; only the file name has changed. For the WebView2Mac project, this change means that any downstream code directly referencing "ui/gfx/native_widget_types.h" will need to be updated accordingly to "ui/gfx/native_window_types.h". However, since WebView2Mac primarily inherits from and uses classes and interfaces from remote_cocoa, and the actual definitions of these classes and interfaces remain unchanged, the core functionality of WebView2Mac will not be affected. The only point to note is that if there are direct inclusions of this header file in WebView2Mac's downstream code, the file name should be updated accordingly.
Impacted Classes:
NativeWidgetNSWindowBridge
ImmersiveModeControllerCocoa
NativeWidgetMacNSWindow
ApplicationHost
ScopedNativeWindowMapping