Remove redundant processedWheelEvent and related calls
Minor
Commit Hash:
1342b6a68108bbe28f067263156bfc83cc19d7a2
Commit Time: 2025-03-21 02:42:57+00:00
Impact Level: Minor
Generated By: webview2-upstream-sentry
Upstream Review:
View Upstream Review 🔗
📋 Summary
This submission primarily removes the processedWheelEvent and rendererHandledWheelEvent methods and their related invocations. These methods were originally used for callbacks after the renderer handled mouse wheel events, but are no longer in use. The changes involve deleting interface declarations, implementations, related header file references, and invocations in unit tests. The affected files are distributed across the chrome and content directories, including remote_cocoa-related files such as render_widget_host_view_cocoa.mm and render_widget_host_view_mac_delegate.h.
🎯 Impact Analysis
This change is a cleanup of unused interfaces and implementations, without introducing new features or modifying existing business logic. For WebView2Mac, if downstream code does not override or depend on the processedWheelEvent/rendererHandledWheelEvent related interfaces, there will be no functional or performance impact. If downstream code has custom implementations or calls to these interfaces, the corresponding code must be removed synchronously; otherwise, compilation errors will occur. From a dependency perspective, WebView2Mac mainly relies on core functionalities such as window and view bridging in remote_cocoa and Mojo interfaces, which are not affected by this change. Therefore, the impact of this submission on WebView2Mac is minimal, and only interface synchronization needs to be noted.
Impacted Classes:
RenderWidgetHostViewCocoa
RenderWidgetHostViewMacDelegate