Remove support code for macOS 11 and earlier versions
Minor
提交哈希:
1121fdd5f545ac2c335b914374ed7a510e53afdc
提交时间: 2025-05-29 16:46:29+00:00
影响等级: Minor
生成工具: webview2-upstream-sentry
上游审核链接:
查看上游审核 🔗
📋 摘要
This submission primarily removes support code for macOS 11 and earlier versions from Chromium. The main changes include:
1. Removal of version check conditional code in remote_cocoa related files, including immersive mode controller and window management functionalities.
2. Simplification of secure coding implementations, with the removal of conditional checks for macOS 12+.
3. Update of toolbar separator handling logic, eliminating special processing for macOS 10.15 and earlier versions.
4. Removal of version compatibility code related to NSToolbar and safe area.
This change is a code cleanup and maintenance update, does not involve changes to functional logic, and only simplifies version compatibility code.
1. Removal of version check conditional code in remote_cocoa related files, including immersive mode controller and window management functionalities.
2. Simplification of secure coding implementations, with the removal of conditional checks for macOS 12+.
3. Update of toolbar separator handling logic, eliminating special processing for macOS 10.15 and earlier versions.
4. Removal of version compatibility code related to NSToolbar and safe area.
This change is a code cleanup and maintenance update, does not involve changes to functional logic, and only simplifies version compatibility code.
🎯 影响分析
The impact on WebView2Mac is relatively minor, but attention should be paid to the following aspects:
1. **Minimum System Requirement Change**: If downstream WebView2Mac code depends on the compatibility code being removed, it may be necessary to raise the minimum system version requirement to macOS 12 or higher.
2. **Immersive Fullscreen Functionality**: Special handling for macOS 11 has been removed from immersive_mode_controller_cocoa.mm. If WebView2Mac uses immersive fullscreen functionality, it is necessary to ensure proper operation on newer macOS versions.
3. **Window Management and Secure Coding**: Conditional version checks have been removed from native_widget_mac_nswindow.mm, and secure coding is now used universally. This improves security but may affect compatibility with older macOS versions.
4. **Toolbar Handling**: Special handling for old version toolbar separators has been removed. If WebView2Mac has a custom toolbar implementation, it is necessary to verify correct operation under the new unified handling logic.
As this is a maintenance change, the main risk lies in the increased compatibility requirements, but the functional logic itself remains unchanged.
1. **Minimum System Requirement Change**: If downstream WebView2Mac code depends on the compatibility code being removed, it may be necessary to raise the minimum system version requirement to macOS 12 or higher.
2. **Immersive Fullscreen Functionality**: Special handling for macOS 11 has been removed from immersive_mode_controller_cocoa.mm. If WebView2Mac uses immersive fullscreen functionality, it is necessary to ensure proper operation on newer macOS versions.
3. **Window Management and Secure Coding**: Conditional version checks have been removed from native_widget_mac_nswindow.mm, and secure coding is now used universally. This improves security but may affect compatibility with older macOS versions.
4. **Toolbar Handling**: Special handling for old version toolbar separators has been removed. If WebView2Mac has a custom toolbar implementation, it is necessary to verify correct operation under the new unified handling logic.
As this is a maintenance change, the main risk lies in the increased compatibility requirements, but the functional logic itself remains unchanged.
受影响的类:
ImmersiveModeControllerCocoa
ImmersiveModeTabbedControllerCocoa
NativeWidgetMacNSWindow
ImmersiveModeTitlebarViewController