📊 Statistics Overview
118
Total Reports
1
Major Impact
52
Moderate Impact
65
Minor Impact
🔍 Search & Filter
📋 Report List
Commit:
f22815ca 🔗
Time: 2025-12-06 02:32:25+00:00
This commit is an IWYU (Include What You Use) refactoring that explicitly adds #include "base/notreached.h" to 57 files that use the NOTREACHED() macro. These changes are in preparation for an upcomin...
Impacted Classes:
remote_cocoa::mojom::FontDataView
remote_cocoa::mojom::SystemFont
remote_cocoa::mojom::FontWeight
+2 more
Commit:
00d09a69 🔗
Time: 2025-12-05 02:30:01+00:00
This commit modifies the NativeWidgetNSWindowBridge::SetSizeAndCenter() method to implement a long-standing TODO: center child windows relative to their parent window instead of the screen when a pare...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
NativeWidgetNSWindowBridge::SetSizeAndCenter
Commit:
c9401b77 🔗
Time: 2025-12-03 01:50:39+00:00
This commit introduces a deferred notification mechanism in render_widget_host_view_cocoa.mm to handle edge cases in window focus state changes. The implementation includes: adding a class-level weak ...
Impacted Classes:
RenderWidgetHostViewCocoa
remote_cocoa::WebContentsNSViewBridge (间接影响/indirectly impacted)
Commit:
1f256b3e 🔗
Time: 2025-12-01 22:58:12+00:00
This commit removes the unused #include of receiver.h from mojo/public/cpp/bindings/associated_receiver.h. To compensate, explicit #include "mojo/public/cpp/bindings/receiver.h" declarations were adde...
Impacted Classes:
remote_cocoa::RenderWidgetHostNSViewBridge
mojo::AssociatedReceiver
mojo::Receiver
Commit:
679e39bc 🔗
Time: 2025-11-26 04:17:23+00:00
This commit reverts a change to the macOS window key status checking mechanism. The original change modified the condition check in the `-windowDidResignKey:` method from `[NSApp keyWindow] == [self w...
Impacted Classes:
RenderWidgetHostViewCocoa
remote_cocoa::mojom::RenderWidgetHostNSViewHost
Commit:
16723c11 🔗
Time: 2025-11-26 01:32:26+00:00
This commit is a large-scale code cleanup that removes the inclusion of base/functional/callback_forward.h from 264 files. Most of these files are .cc and .mm implementation files. According to the co...
Impacted Classes:
remote_cocoa::ImmersiveModeTabbedControllerCocoa
Commit:
4f0076b9 🔗
Time: 2025-11-25 19:16:22+00:00
This commit relands the fix from r1547376, but scopes the constrainFrameRect override to only apply to child windows. It modifies the constrainFrameRect:toScreen: method in NativeWidgetMacNSWindow cla...
Impacted Classes:
remote_cocoa::NativeWidgetMacNSWindow
remote_cocoa::NativeWidgetNSWindowBridge
Commit:
c11b2d1c 🔗
Time: 2025-11-25 18:53:03+00:00
This commit primarily adds integration tests for App Shim to verify the scenario where Chrome is launched by an App Shim while Chrome is not running. To support these tests, several infrastructure imp...
Impacted Classes:
remote_cocoa::ApplicationBridge
remote_cocoa::NativeWidgetNSWindowBridge
Commit:
20ea6a57 🔗
Time: 2025-11-21 17:15:24+00:00
This commit relands a previously reverted fix that changes the key window status check in the windowDidResignKey method from `[NSApp keyWindow] == [self window]` to `[self window].isKeyWindow`. This f...
Impacted Classes:
RenderWidgetHostViewCocoa
remote_cocoa::mojom::RenderWidgetHostNSViewHost
Commit:
d6834320 🔗
Time: 2025-11-19 22:36:08+00:00
This commit reverts a previous modification to the NativeWidgetMacNSWindow::constrainFrameRect:toScreen: method. The reverted code simplified this method's logic to directly return the original frameR...
Impacted Classes:
NativeWidgetMacNSWindow
remote_cocoa::NativeWidgetNSWindowBridge
Commit:
ecca6d0c 🔗
Time: 2025-11-19 19:39:52+00:00
This commit modifies the -constrainFrameRect:toScreen: method implementation in NativeWidgetMacNSWindow. The previous implementation included conditional logic to avoid AppKit's menu bar collision han...
Impacted Classes:
NativeWidgetMacNSWindow
remote_cocoa::NativeWidgetNSWindowBridge
ViewsTestBase
Commit:
bd9ba8bf 🔗
Time: 2025-11-17 23:56:34+00:00
This commit primarily performs code cleanup by removing unused Mojo binding-related include statements from header files in the //content directory. Specifically removed includes are:
- mojo/public/cp...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
4b4dec94 🔗
Time: 2025-11-14 19:48:35+00:00
This commit fixes two related issues on macOS: (1) When clicking a menu item while the app is inactive, AppKit can enter a "half-activated" state where the app won't fully activate; (2) The NSWindowDi...
Impacted Classes:
remote_cocoa::CocoaMouseCapture
remote_cocoa::CocoaMouseCapture::ActiveEventTap
views::MenuCocoaWatcherMac
+1 more
Commit:
c16aa897 🔗
Time: 2025-11-14 18:27:39+00:00
This commit reverts a change that modified the window focus status detection logic. The original change replaced the condition check in the `windowDidResignKey:` method from `[NSApp keyWindow] == [sel...
Impacted Classes:
RenderWidgetHostViewCocoa
remote_cocoa::mojom::RenderWidgetHostNSViewHost
Commit:
5c0d2189 🔗
Time: 2025-11-14 09:31:53+00:00
This commit modifies the WebContentsViewMac::ViewsHostableSetBounds method to accept coordinates relative to the superview rather than the window (NSWindow). The change includes the following core mod...
Impacted Classes:
remote_cocoa::WebContentsNSViewBridge
remote_cocoa::mojom::WebContentsNSView
remote_cocoa::mojom::WebContentsNSViewHost
+2 more
Commit:
45af5838 🔗
Time: 2025-11-12 05:11:07+00:00
This commit fixes the misplaced Omnibox popup issue caused by new child NSWindow positioning restrictions in macOS 26. macOS 26 adds new constraints to child window positioning: in fullscreen mode, it...
Impacted Classes:
NativeWidgetMacNSWindow
NativeWidgetMacOverlayNSWindow
remote_cocoa::NativeWidgetNSWindowBridge
Commit:
b68f9597 🔗
Time: 2025-11-10 21:13:42+00:00
This commit adds a utility function CloseNSPopovers() in immersive_mode_controller_cocoa.mm to close all open NSPopover windows before entering immersive fullscreen mode. This change addresses an AppK...
Impacted Classes:
remote_cocoa::ImmersiveModeControllerCocoa
Commit:
15e4e76e 🔗
Time: 2025-11-06 05:05:21+00:00
This commit adds a new feature on macOS that automatically cancels ongoing IME (Input Method Editor) composition when a window loses focus. The specific changes include:
1. A new macOS-specific featur...
Impacted Classes:
RenderWidgetHostViewCocoa
features::kCancelCompositionWhenWindowLosesFocus
Commit:
d1224ed9 🔗
Time: 2025-10-31 00:54:42+00:00
This commit fixes a race condition in the windowDidResignKey: method in render_widget_host_view_cocoa.mm. The condition check was changed from [NSApp keyWindow] == [self window] to [self window].isKey...
Impacted Classes:
RenderWidgetHostViewCocoa
remote_cocoa::mojom::RenderWidgetHostNSViewHost
Commit:
22f82a9e 🔗
Time: 2025-10-30 17:57:59+00:00
This submission primarily fixes the inconsistent state issue that may occur when a window fails to enter fullscreen mode on macOS. The current implementation relies on the `windowDidExitFullScreen` no...
Impacted Classes:
NativeWidgetNSWindowFullscreenController
ViewsNSWindowDelegate
NativeWidgetMacNSWindowHost
Commit:
7060fa47 🔗
Time: 2025-10-30 14:30:14+00:00
This submission removes the "MacImeLiveConversionFix" feature flag and its related implementation, which has already been enabled by default. The feature flag has been enabled by default since version...
Impacted Classes:
RenderWidgetHostViewCocoa
features::kMacImeLiveConversionFix
Commit:
b92640e2 🔗
Time: 2025-10-24 23:58:15+00:00
This submission introduces a new ui::ClipboardUrlInfo struct to support the functionality of dragging multiple URLs. The main changes include: 1) Addition of the ui::ClipboardUrlInfo struct, which con...
Impacted Classes:
content::DropData
ui::ClipboardUrlInfo
WebDragSource (web_drag_source_mac.mm)
+2 more
Commit:
3940dc26 🔗
Time: 2025-10-20 18:47:39+00:00
This commit adds a notification mechanism for the display and closure of sheet modal windows (such as file pickers) on macOS. The main changes include: adding windowWillBeginSheet and windowDidEndShee...
Impacted Classes:
NativeWidgetNSWindowHost
NativeWidgetNSWindowBridge
ViewsNSWindowDelegate
+2 more
Commit:
b7c93465 🔗
Time: 2025-10-20 16:38:27+00:00
This commit modifies the handling of visibility state changes in headless mode. In headless mode, the visibility state is now checked to determine if an actual change has occurred, and the OnVisibilit...
Impacted Classes:
NativeWidgetNSWindowBridge
HostingNSWindowBridge
Commit:
f198a198 🔗
Time: 2025-10-14 21:36:36+00:00
This submission primarily fixes rendering issues with multiple Chrome windows under specific Stage Manager configurations on macOS 26. The main changes include: 1) Updating the version check logic in ...
Impacted Classes:
WebContentsOcclusionCheckerMac
WebContentsViewCocoa
Commit:
ef7df6d1 🔗
Time: 2025-10-13 21:04:54+00:00
This submission primarily fixes C++23 compilation errors on the Mac platform. Specifically, it includes two modifications: 1) In chrome/updater/net/network_fetcher_mac.mm, the std::string constructor ...
Impacted Classes:
SelectFileDialogBridge
SelectFileDialogBridge::ScopedPreventKeyWindow
Commit:
4b8fec20 🔗
Time: 2025-10-10 21:40:02+00:00
This submission removes conversion functions between NSRect, NSPoint, NSSize and CGRect, CGPoint, CGSize that are no longer needed in the macOS 64-bit environment. In macOS 64-bit systems, Apple direc...
Impacted Classes:
ImmersiveModeControllerCocoa
RenderWidgetHostViewCocoa
WebContentsNSViewBridge
Commit:
d3d81eae 🔗
Time: 2025-10-06 18:51:43+00:00
This submission primarily removes redundant mojom include files from the //content/public header files. Since mojom code contains the "mojom::" string in its namespace, files in those headers that do ...
Impacted Classes:
WebContentsOcclusionCheckerMac
Commit:
7c8a1666 🔗
Time: 2025-09-30 19:13:38+00:00
This submission is a rollback of a previous patch that fixed the issue of download bubble closure in macOS fullscreen windows. The original patch modified the EventMonitor implementation for macOS to ...
Impacted Classes:
remote_cocoa::mojom::NativeWidgetNSWindowHost
remote_cocoa::NativeWidgetNSWindowBridge
views::NativeWidgetMacEventMonitor::Client
+3 more
Commit:
bdd2c586 🔗
Time: 2025-09-29 17:00:23+00:00
This submission addresses the issue where the download bubble could not be properly closed in the macOS fullscreen window environment. The main changes include: 1) Modifying the download toolbar UI co...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
remote_cocoa::mojom::NativeWidgetNSWindowHost
views::NativeWidgetMacEventMonitor::Client
+2 more
Commit:
6a3bc73c 🔗
Time: 2025-09-25 15:53:17+00:00
This submission introduces a window filtering mechanism for the event monitoring functionality of remote cocoa windows. The DispatchMonitorEvent interface has been modified to add a boolean parameter,...
Impacted Classes:
remote_cocoa::mojom::NativeWidgetNSWindowHost
remote_cocoa::NativeWidgetNSWindowBridge
views::NativeWidgetMacNSWindowHost
+3 more
Commit:
bbaf3c3c 🔗
Time: 2025-09-24 21:11:10+00:00
This submission reverts the previously implemented macOS main window content area click-through functionality. The original implementation added complex logic in the acceptsFirstMouse: method, determi...
Impacted Classes:
RenderWidgetHostViewCocoa
AcceptMouseEvents (枚举)
Commit:
cd41e985 🔗
Time: 2025-09-22 18:11:22+00:00
This submission removes the is_headless_mode member flag variable in Mac headless mode. The main changes include: 1) In native_widget_ns_window_bridge.mm, the check for params->is_headless_mode_window...
Impacted Classes:
remote_cocoa::mojom::NativeWidgetNSWindowInitParams
remote_cocoa::NativeWidgetNSWindowBridge
views::NativeWidgetMacNSWindowHost
+1 more
Commit:
e49235e0 🔗
Time: 2025-09-18 18:16:36+00:00
This submission modifies the implementation of the acceptsFirstMouse: method in RenderWidgetHostViewCocoa on macOS. The previous simple conditional logic has been replaced with a more detailed switch ...
Impacted Classes:
RenderWidgetHostViewCocoa
RenderWidgetHostViewMacDelegate
AcceptMouseEvents
Commit:
6a5aa671 🔗
Time: 2025-09-17 14:46:20+00:00
This submission rolls back the previous change regarding the click-through behavior of the main window content area on macOS. The original change attempted to reduce the restrictions on click-through,...
Impacted Classes:
RenderWidgetHostViewCocoa
AcceptMouseEvents
Commit:
a91f3332 🔗
Time: 2025-09-16 05:51:24+00:00
This commit fixes the issue of frequent main thread calculations caused by using the firstBaselineAnchor property of NSPopUpButton for auto layout on macOS 26. Starting from macOS 26, the firstBaselin...
Impacted Classes:
remote_cocoa::SelectFileDialogBridge
remote_cocoa::mojom::Application
Commit:
67735866 🔗
Time: 2025-09-16 05:15:54+00:00
This submission is an automated refactoring that migrates the BASE_FEATURE macro throughout the //components directory from the three-parameter version to the two-parameter version, ensuring that the ...
Impacted Classes:
remote_cocoa::features::kImmersiveFullscreenSpaceSwitchMitigation
remote_cocoa::features::kImmersiveFullscreenOverlayWindowDebug
Commit:
d8dc9460 🔗
Time: 2025-09-11 16:49:44+00:00
This submission is primarily aimed at improving accessibility features, ensuring that VoiceOver can correctly read the "new" label marked as a new feature in menu items. The main changes include: 1) R...
Impacted Classes:
MenuControllerCocoaDelegateImpl
remote_cocoa::mojom::MenuControllerParams
Commit:
cd7ba50a 🔗
Time: 2025-09-10 12:38:20+00:00
This submission fixes a system compatibility issue in macOS 26.0. In macOS 26.0, when the main window enters fullscreen mode, the system automatically adjusts the position of overlay sub-windows to be...
Impacted Classes:
NativeWidgetMacOverlayNSWindow
ImmersiveModeControllerCocoa
ImmersiveModeTabbedControllerCocoa
Commit:
956ccf28 🔗
Time: 2025-09-09 22:47:02+00:00
This submission primarily renames the header file "ui/gfx/native_widget_types.h" to "ui/gfx/native_ui_types.h", and updates the corresponding #include references in 54 files. This is a purely header f...
Impacted Classes:
render_widget_host_view_cocoa.mm (仅头文件引用变更)
Fix the issue of resetting the hit test target when TabTitlebarView is removed in fullscreen mode
Moderate
Commit:
9aac7d8c 🔗
Time: 2025-09-08 17:10:00+00:00
This submission primarily addresses a race condition issue that occurred when TabTitlebarView was removed from NSToolbarFullScreenWindow in fullscreen mode. Specific changes include: 1) Modified the S...
Impacted Classes:
SetNSNextStepFrameHitTestTargetView
TabTitlebarView
remote_cocoa::ImmersiveModeTabbedControllerCocoa
Commit:
16e216bf 🔗
Time: 2025-09-05 22:47:23+00:00
This submission is a large-scale header file renaming operation, replacing all references to "ui/gfx/native_window_types.h" with "ui/gfx/native_ui_types.h" throughout the //components directory. The c...
Impacted Classes:
NativeWidgetNSWindowBridge
ApplicationHost
ScopedNativeWindowMapping
Commit:
068d8bb6 🔗
Time: 2025-09-03 16:34:26+00:00
This submission modifies the implementation of the acceptsFirstMouse: method in the render_widget_host_view_cocoa.mm file. The original implementation simply checked whether the mouse event acceptance...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
629f92e0 🔗
Time: 2025-09-01 19:15:29+00:00
This submission removes debugging-related code from the components/remote_cocoa/app_shim/override_ns_next_step_frame_hit_test.mm file. Specific changes include: deleting references to the base/debug/s...
Impacted Classes:
NSNextStepFrame (系统类的方法重载)
Commit:
bba7ce65 🔗
Time: 2025-08-29 20:12:04+00:00
This submission implements a new fix for the issue of right-clicking on the title bar in macOS 26. The main changes include: removal of the original NSToolbarView swizzling mechanism (swizzle_ns_toolb...
Impacted Classes:
remote_cocoa::ImmersiveModeTabbedControllerCocoa
NSNextStepFrame(新重写的AppKit类)
TabTitlebarView(新增的自定义视图类)
+1 more
Commit:
ed452792 🔗
Time: 2025-08-28 18:41:30+00:00
This commit removes the call to DestroyContentView() in the NativeWidgetNSWindowBridge::CloseWindow() method. The previous purpose of this call was to destroy the NSView of the NSWindow when the windo...
Impacted Classes:
NativeWidgetNSWindowBridge
HostingNSWindowBridge
BridgedContentView
+1 more
Commit:
4e2f3f33 🔗
Time: 2025-08-27 23:46:15+00:00
This submission is the ninth part of a large-scale renaming operation, mainly replacing all references to the "ui/gfx/native_widget_types.h" header file with "ui/gfx/native_window_types.h" under the c...
Impacted Classes:
NativeWidgetNSWindowBridge
ImmersiveModeControllerCocoa
NativeWidgetMacNSWindow
+2 more
Commit:
762365aa 🔗
Time: 2025-08-26 17:47:46+00:00
This submission separates the ui/base/interaction module from the main ui/base BUILD.gn file, creating an independent BUILD target "//ui/base/interaction". The purpose of this change is to allow acces...
Impacted Classes:
remote_cocoa::app_shim (BUILD依赖变更)
ElementIdentifier (导出宏变更)
ElementTracker (导出宏变更)
+7 more
Commit:
4396901b 🔗
Time: 2025-08-26 15:14:06+00:00
This submission mainly replaces the `WTF::` namespace in the code with the `blink::` namespace, which is part of Chromium’s ongoing namespace refactoring. Specific changes include: 1) In the content/a...
Impacted Classes:
无相关类受影响(仅注释变更)
Commit:
43525428 🔗
Time: 2025-08-25 15:01:27+00:00
This submission adds an experimental fix for macOS 26 to address the issue where right-clicking the tabstrip in fullscreen mode fails to trigger the context menu. The main changes include: 1) Adding s...
Impacted Classes:
ImmersiveModeTabbedControllerCocoa
SwizzleNSToolbarViewHitTest (新增函数)
NSToolbarView (系统类,通过 swizzling 修改)
Commit:
9ac4d00a 🔗
Time: 2025-08-21 17:09:12+00:00
This submission removes a line of debug log code that was accidentally committed in the `components/remote_cocoa/app_shim/select_file_dialog_bridge.mm` file. Specifically, it removes the `NSLog(@"drop...
Impacted Classes:
SelectFileDialogBridge
Commit:
b62fe223 🔗
Time: 2025-08-21 14:33:53+00:00
This submission fixes an issue encountered when using the deprecated NSOpenPanel API: when folder selection is disabled, the open panel would sometimes incorrectly treat folders as packages and return...
Impacted Classes:
SelectFileDialogBridge
NSOpenPanel (macOS 系统类)
Commit:
1cea8804 🔗
Time: 2025-08-20 21:41:03+00:00
This submission replaces all instances of display::Screen::GetScreen() with display::Screen::Get() in files under the content/ directory. This is a global API migration affecting 29 files, including r...
Impacted Classes:
display::Screen
RenderWidgetHostViewCocoa
Commit:
ca6ea1cd 🔗
Time: 2025-08-20 18:35:40+00:00
This submission primarily addresses a potential deadlock issue that may occur when dragging from a PWA to the Chrome browser. The changes include: 1) Adding static methods IsOutOfProcessAppShim() and ...
Impacted Classes:
remote_cocoa::ApplicationBridge
WebDragSource
remote_cocoa::mojom::WebContentsNSViewHost
Commit:
24a2f153 🔗
Time: 2025-08-20 07:07:36+00:00
This submission replaces all instances of display::Screen::GetScreen() with display::Screen::Get() in the //components directory. This is a simple function renaming; the functionality remains exactly ...
Impacted Classes:
ImmersiveModeControllerCocoa
NativeWidgetNSWindowBridge
Commit:
58968d57 🔗
Time: 2025-08-14 00:26:52+00:00
This submission primarily addresses the issue of a horizontal white gap caused by an excessively high tab strip area in macOS 26 fullscreen mode. The fix involves setting the main window’s toolbar sty...
Impacted Classes:
ImmersiveModeTabbedControllerCocoa
ImmersiveModeControllerCocoa
remote_cocoa::NativeWidgetNSWindowBridge
Commit:
3ff41a90 🔗
Time: 2025-08-13 22:44:21+00:00
This submission rolls back a fix for the right-click event handling issue in NSToolbarView on macOS 26. The reverted code includes the deletion of the swizzle_ns_toolbar_view_hit_test.h and swizzle_ns...
Impacted Classes:
remote_cocoa::ImmersiveModeTabbedControllerCocoa
SwizzleNSToolbarViewHitTest
Commit:
a679ed94 🔗
Time: 2025-08-12 21:03:46+00:00
This commit fixes two issues in macOS 26 full-screen mode: 1) The tab bar area was too tall, resulting in a horizontal white gap. This is resolved by ensuring the main window’s toolbar style is Unifie...
Impacted Classes:
ImmersiveModeTabbedControllerCocoa
NSToolbarView
remote_cocoa::SwizzleNSToolbarViewHitTest
Commit:
b28ae82f 🔗
Time: 2025-08-12 05:56:59+00:00
This submission primarily addresses the issue of text replacement suggestion conflicts caused by redundant selection synchronization in EditContext. The core changes include: 1) At the remote_cocoa la...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
501230de 🔗
Time: 2025-08-04 21:37:51+00:00
This submission mainly improves the WebShare functionality on the macOS platform by changing the URL parameter type from string to GURL. The main changes include: 1) Modifying the ShowSharingServicePi...
Impacted Classes:
remote_cocoa::RenderWidgetHostNSViewBridge
remote_cocoa::mojom::RenderWidgetHostNSView
content::RenderWidgetHostView
+2 more
Commit:
1334f236 🔗
Time: 2025-08-04 16:07:50+00:00
This submission fixes unsafe buffer usage issues in the `native_widget_mac_nswindow.mm` file. The main changes include: 1) removing the `UNSAFE_BUFFERS_BUILD` preprocessor directive and `#pragma allow...
Impacted Classes:
NativeWidgetMacNSWindow
remote_cocoa::NativeWidgetNSWindowBridge
Commit:
b80b2b99 🔗
Time: 2025-07-28 18:58:07+00:00
This submission primarily involves automatic formatting of GN build files (BUILD.gn) in certain subdirectories under the //components/ directory that start with [p-z]. Specific operations include: usi...
Impacted Classes:
无(此次变更未涉及 remote_cocoa 相关类或接口,仅为 BUILD.gn 构建文件格式化)
Commit:
cab606d1 🔗
Time: 2025-07-16 20:53:37+00:00
This submission primarily automates the cleanup of obsolete `#pragma allow_unsafe_buffers` compiler directives from various source files. The directive was originally used to permit unsafe buffer oper...
Impacted Classes:
无(remote_cocoa 相关类和接口未受影响)
Commit:
544290d5 🔗
Time: 2025-07-15 18:20:25+00:00
This submission was generated by the Owners Cleanup automation bot. The main change is the removal of lgrey@chromium.org from the content/app_shim_remote_cocoa/OWNERS file. This is a suggested change ...
Commit:
7219e0d8 🔗
Time: 2025-07-14 20:38:21+00:00
This submission mainly targets the macOS 26 system, adjusting the alignment and corner radius strategy for window controls (such as title bar buttons/traffic lights). Specifically, on macOS 26, the le...
Impacted Classes:
NativeWidgetNSWindowBridge
BrowserWindowFrame
HostingNSWindowBridge(如下游继承自上游该类)
+2 more
Commit:
bc5784f0 🔗
Time: 2025-06-19 19:35:05+00:00
This submission is an IWYU (Include What You Use) code cleanup, primarily adding the "base/notimplemented.h" header file reference to files using the NOTIMPLEMENTED() macro under the //components dire...
Impacted Classes:
BridgedContentView
Commit:
d5b61017 🔗
Time: 2025-06-17 17:21:01+00:00
This submission uses the IWYU (Include What You Use) tool to add missing <vector> header file references to 107 header files under the components directory. This is a code robustness improvement to en...
Impacted Classes:
MojoMenuModel
Commit:
c51d3b08 🔗
Time: 2025-06-13 22:22:17+00:00
This submission primarily adds the missing "base/trace_event/trace_event.h" header file references to multiple source files related to input event handling. The affected files include modules such as ...
Impacted Classes:
RenderWidgetHostViewCocoa
ChildFrameInputHelper
MouseWheelEventQueue
+5 more
Commit:
cdd0e6f4 🔗
Time: 2025-06-12 21:38:36+00:00
This submission modifies the font setting logic for accessory view labels in the file chooser dialog. Specifically, a macOS version check is added in the CreateAccessoryView() function: when macOS ver...
Impacted Classes:
SelectFileDialogBridge
CreateAccessoryView (函数)
Commit:
2e0b5fd8 🔗
Time: 2025-06-10 21:58:08+00:00
This submission performs a comprehensive cleanup and refactoring of the historical swipe code. The main changes include:
1. Renamed the AcceptMouseEventsOption enum to AcceptMouseEvents and converted ...
Impacted Classes:
AcceptMouseEvents
HistorySwiper
RenderWidgetHostViewCocoa
+2 more
Commit:
16b9b1c9 🔗
Time: 2025-06-05 17:56:29+00:00
This submission fixes an issue where opening the save panel from an extension popup in fullscreen mode causes the popup to close unexpectedly. When the save panel is closed, AppKit activates the panel...
Impacted Classes:
NativeWidgetMacNSWindow
NativeWidgetNSWindowBridge
SelectFileDialogBridge
Commit:
eabf39b4 🔗
Time: 2025-06-04 20:54:46+00:00
This submission removes redundant references to gurl.h from 24 header files under the //content directory. None of these header files directly reference the GURL type, so including gurl.h is unnecessa...
Impacted Classes:
WebDragSource
Commit:
5299d367 🔗
Time: 2025-06-04 18:20:09+00:00
This commit fixes a bug in event routing for windows with a title bar. Previously, the bottom area of the window stopped receiving mouse events because the code incorrectly used window or parent view ...
Impacted Classes:
BridgedContentView
RenderWidgetHostViewCocoa
Commit:
3e5f1d81 🔗
Time: 2025-06-04 17:12:31+00:00
This submission removes the gesture event compatibility code for early macOS versions (OS X 10.10), simplifying the gesture handling logic in RenderWidgetHostViewCocoa. The main changes include: 1) de...
Impacted Classes:
RenderWidgetHostViewCocoa
RenderWidgetHostNSViewHostHelper
RenderWidgetHostViewMac
+2 more
PWA Transparent Area Event Penetration Fix and Window Controls Overlay Related Code Cleanup
Moderate
Commit:
7a87e1fe 🔗
Time: 2025-06-03 18:35:57+00:00
This submission fixes a regression issue on macOS where, after enabling the Window Controls Overlay (WCO) feature for PWAs, mouse events could not correctly reach the web content in the transparent ti...
Impacted Classes:
WebContentsViewCocoa
WebContentsNSViewBridge
TopContainerView
+1 more
Commit:
bb6a9b9a 🔗
Time: 2025-06-03 16:41:00+00:00
This submission primarily removes RenderWidgetHostViewCocoa’s dependency on legacy gesture events (beginGestureWithEvent: and endGestureWithEvent:) and introduces modernization improvements. On macOS ...
Impacted Classes:
RenderWidgetHostViewMacDelegate
RenderWidgetHostViewCocoa
HistorySwiper
+3 more
Commit:
f40ac9a6 🔗
Time: 2025-06-02 22:35:10+00:00
This submission is part of "Do IWYU for base/strings/string_util.h in //content", adding direct references to the "base/strings/string_util.h" header file in multiple files to replace previous transit...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
8c004781 🔗
Time: 2025-06-02 17:47:44+00:00
This submission primarily fixes the issue of lost mouse press and release events in the top-chrome area (top toolbar area) under fullscreen mode. The problem originated from a previous submission (htt...
Impacted Classes:
BridgedContentView
NativeWidgetMacNSWindowHost
HitTestResult
Commit:
1121fdd5 🔗
Time: 2025-05-29 16:46:29+00:00
This submission primarily removes support code for macOS 11 and earlier versions from Chromium. The main changes include:
1. Removal of version check conditional code in remote_cocoa related files, in...
Impacted Classes:
ImmersiveModeControllerCocoa
ImmersiveModeTabbedControllerCocoa
NativeWidgetMacNSWindow
+1 more
Commit:
420b0efb 🔗
Time: 2025-05-28 17:07:37+00:00
This submission modifies the mouse event routing mechanism on macOS, resolving the issue where views overlaying the content area (hosted in a view::WebView) could not receive mouse up and down events....
Impacted Classes:
BridgedContentView
NativeWidgetMacNSWindowHost
remote_cocoa::mojom::NativeWidgetNSWindowHost
+1 more
Commit:
cd98c2e6 🔗
Time: 2025-05-19 18:59:38+00:00
This submission primarily cleans up unnecessary ui/gfx-related header file inclusions in multiple header files under the components directory. The change is based on the following principle: ui/gfx co...
Impacted Classes:
AlertBridge
MenuControllerCocoaDelegateImpl
Commit:
48d9baba 🔗
Time: 2025-05-16 18:22:18+00:00
This submission is a rollback operation, reverting previous modifications related to the Mac text replacement feature. The original changes attempted to ignore outdated text replacement operations by ...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
bf580212 🔗
Time: 2025-05-14 23:45:46+00:00
This submission modifies the handling mechanism of text replacement callbacks on macOS. The main changes include: replacing the parameter of the text replacement callback method from change counter (c...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
edf57482 🔗
Time: 2025-05-06 21:23:23+00:00
This submission unifies the modification of all COMPONENT_EXPORT-related header files in Chromium, changing the export symbol visibility from conditional export to always set as visible on non-Windows...
Impacted Classes:
REMOTE_COCOA_APP_SHIM_EXPORT
REMOTE_COCOA_BROWSER_EXPORT
COMPONENT_EXPORT_ANNOTATION
+1 more
Rollback the out-of-order text replacement ignore mechanism in the text replacement feature
Moderate
Commit:
ad319148 🔗
Time: 2025-05-05 19:03:33+00:00
This submission is a rollback of the previous commit d5bf4ba9cd66ce8bc28939a6807777403f295259. The original commit aimed to prevent crashes by ignoring text corrections for legacy web content, but thi...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
e8074166 🔗
Time: 2025-05-05 18:54:40+00:00
This submission is a rollback operation, reverting the previous changes made in commit 20f7c0ec898720267e9d3aaae252edf1551469d5 regarding the Mac text replacement checking logic. The original modifica...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
20f7c0ec 🔗
Time: 2025-05-02 22:17:20+00:00
This submission primarily fixes a regression in the text replacement functionality caused by http://crrev/c/6299632. The change moves the check of the `_substitutionWasApplied` flag and the invocation...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
c7d7fd80 🔗
Time: 2025-04-29 21:08:16+00:00
This submission primarily removes the methods for manually adding and removing AXMode flags (AddAccessibilityModeFlags and RemoveAccessibilityModeFlags) in BrowserAccessibilityState, switching to a un...
Impacted Classes:
RenderWidgetHostViewCocoa
BrowserAccessibilityStateImpl
ScopedAccessibilityMode
+1 more
Commit:
777fab94 🔗
Time: 2025-04-29 19:14:28+00:00
This submission primarily cleans up the obsolete feature flag `kImmersiveFullscreenTabs`. Specific changes include: removing the definition and declaration of the `kImmersiveFullscreenTabs` feature fl...
Impacted Classes:
ImmersiveModeControllerCocoa
ImmersiveModeTabbedControllerCocoa
NativeWidgetNSWindow
Commit:
e7c8be57 🔗
Time: 2025-04-23 18:45:47+00:00
This submission introduces a new API, Widget::IsVisibleOnScreen(), for detecting whether a Widget is visible to the user on the screen. This API differentiates between the existing IsVisible() (which ...
Impacted Classes:
NativeWidgetNSWindowBridge
ViewsNSWindowDelegate
NativeWidgetNSWindowHost
+2 more
Commit:
5a8bf02a 🔗
Time: 2025-04-23 15:12:35+00:00
This submission removes the functionality for hiding the application icon in native macOS popup dialogs. The changes include: 1) deleting the hide_application_icon field from the AlertBridgeInitParams...
Impacted Classes:
AlertBridge
AlertBridgeHelper
AlertBridgeInitParams
Commit:
4646a17d 🔗
Time: 2025-04-18 18:02:46+00:00
This submission fixes an issue where a CHECK error occurs during text reconversion (reconversion, i.e., homophone conversion) in Google Japanese IME due to an invalid replacement range being passed in...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
4bbdb200 🔗
Time: 2025-04-03 01:43:44+00:00
This submission primarily unifies and renames constants related to the clipboard in the Chromium project. Specifically, constants such as kMimeTypeText, kMimeTypeHTML, and kMimeTypeURIList have been r...
Impacted Classes:
无 remote_cocoa 相关类或接口直接受影响(主要影响 ui/base/clipboard 相关常量及其调用处)
Commit:
b7df7f51 🔗
Time: 2025-04-01 20:04:56+00:00
This submission primarily refactors the type definition of NativeViewAccessible on the macOS platform, unifying it from the original raw pointer (id or objc_object*) to the base::apple::OwnedNSAccessi...
Impacted Classes:
NativeWidgetNSWindowBridge
NativeWidgetNSWindowHostHelper
WebContentsNSViewBridge
+5 more
Commit:
346115be 🔗
Time: 2025-04-01 18:47:14+00:00
This submission primarily implements the effect of Widget::InitParams::corner_radius on the macOS platform. Specifically, a corner mask is added to the content view of NSWindow, enabling the window co...
Impacted Classes:
remote_cocoa::mojom::NativeWidgetNSWindow
remote_cocoa::NativeWidgetNSWindowBridge
remote_cocoa::mojom::NativeWidgetNSWindowInitParams
Commit:
0780bb2f 🔗
Time: 2025-03-28 16:26:47+00:00
This submission primarily targets the NativeWidgetMacNSWindow of remote_cocoa on macOS, optimizing the border dragging experience for non-titled resizable windows (such as glic windows). By overriding...
Impacted Classes:
NativeWidgetMacNSWindow
NSWindow (NSWindowResizing category)
Commit:
dbb2c0ab 🔗
Time: 2025-03-25 03:12:48+00:00
This submission relands the feature "Support for DPWA (Desktop Progressive Web App) download bubble dismissal behavior on Mac." The main changes include: renaming key_down_event_monitor_ to local_even...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
views::EventMonitorMac
views::NativeWidgetMacEventMonitor::Client
Commit:
1342b6a6 🔗
Time: 2025-03-21 02:42:57+00:00
This submission primarily removes the processedWheelEvent and rendererHandledWheelEvent methods and their related invocations. These methods were originally used for callbacks after the renderer handl...
Impacted Classes:
RenderWidgetHostViewCocoa
RenderWidgetHostViewMacDelegate
Explicitization of gfx::NativeWidget/View Constructors and Related Call Refactoring on Mac Platform
Moderate
Commit:
83c8682b 🔗
Time: 2025-03-20 16:05:58+00:00
This submission declares the constructors of gfx::NativeView(NSView*) and gfx::NativeWindow(NSWindow*) as explicit on the Mac platform to prevent implicit type conversions. At the same time, it extens...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
remote_cocoa::NativeWidgetNSWindowHostHelper
remote_cocoa::mojom::NativeWidgetNSWindow
+1 more
Commit:
db5d0463 🔗
Time: 2025-03-19 16:25:35+00:00
This submission only adds detailed code comments in the content/app_shim_remote_cocoa/web_menu_runner_mac.mm file regarding the planned replacement of legacy APIs related to menu popups. The comments ...
Impacted Classes:
WebMenuRunner
Commit:
f8ec61d5 🔗
Time: 2025-03-19 02:17:37+00:00
This submission adds a compatibility code segment for the Apple intelligence writing tool in the -[RenderWidgetHostViewCocoa insertText:replacementRange:] method of content/app_shim_remote_cocoa/rende...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
053094ae 🔗
Time: 2025-03-17 23:32:21+00:00
This submission rolls back the previous support for dismiss behavior in the Progressive Web App (PWA) download bubble on Mac. The reverted changes mainly include: undoing the renaming of the local_eve...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
views::EventMonitorMac
views::NativeWidgetMacEventMonitor(接口引用/事件监控相关)
Commit:
d19d7dfd 🔗
Time: 2025-03-17 16:16:17+00:00
This submission adds two event callbacks, OnWidgetUserResizeStarted() and OnWidgetUserResizeEnded(), to the WidgetObserver of the views framework on the macOS platform. It also introduces correspondin...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
remote_cocoa::mojom::NativeWidgetNSWindowHost
ViewsNSWindowDelegate
Commit:
e08093dc 🔗
Time: 2025-03-17 01:50:41+00:00
This submission primarily modernizes and cleans up code related to popup menus, without switching to the new API. Specifically: 1) WebMenuRunner now supports testing via explicit test callbacks, elimi...
Impacted Classes:
WebMenuRunner
MenuControllerCocoa
ContextMenuRunner
Support disappearance behavior of DPWA download bubble on Mac and Remote Cocoa event monitoring
Minor
Commit:
c2e2051b 🔗
Time: 2025-03-13 16:37:34+00:00
This submission primarily implements support for the disappearance behavior of the download bubble in Progressive Web App (PWA) scenarios on Mac. To achieve this, views::EventMonitorMac has been exten...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
views::EventMonitorMac
views::NativeWidgetMacEventMonitor
+1 more
Commit:
57c0d866 🔗
Time: 2025-03-12 18:57:57+00:00
This submission rolls back the previously introduced changes related to "Do popups using modern API" due to a bug on macOS where NSMenu.minimumWidth causes menu items to be truncated prematurely. The ...
Impacted Classes:
MenuControllerCocoa
WebMenuRunner
ContextMenuRunner
+2 more
Commit:
c8c948c2 🔗
Time: 2025-03-11 18:53:26+00:00
This submission shortens the UI painting timeout constant kUIPaintTimeout in the native_widget_ns_window_bridge.mm file of the remote_cocoa component from the original 5 seconds (base::Seconds(5)) to ...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
edge_embedded_browser::HostingNSWindowBridge
Commit:
7b031658 🔗
Time: 2025-03-10 18:38:05+00:00
This submission modifies the components/remote_cocoa/app_shim/native_widget_ns_window_bridge.mm file, adjusting the logic of NativeWidgetNSWindowBridge::ShouldWaitInPreCommit(). Previously, waiting wo...
Impacted Classes:
NativeWidgetNSWindowBridge
Commit:
54da6b24 🔗
Time: 2025-03-07 00:55:53+00:00
This submission reintroduces the approach of “always adding a permanent thin titlebar accessory view controller for windows on macOS 13 and above” to address the issue where, in immersive fullscreen m...
Impacted Classes:
remote_cocoa::ImmersiveModeControllerCocoa
BrowserNativeWidgetWindow (Objective-C)
NSTitlebarAccessoryViewController (使用方式变更)
+1 more
Commit:
812d1901 🔗
Time: 2025-03-05 21:33:06+00:00
This submission rolls back the previous change that "always keeps the thin titlebar accessory view controller present on macOS 13+." The original change aimed to address the race condition issue of th...
Impacted Classes:
remote_cocoa::NativeWidgetNSWindowBridge
remote_cocoa::ImmersiveModeControllerCocoa
remote_cocoa::features(kFullscreenPermanentThinController)
+1 more
Commit:
a87264e5 🔗
Time: 2025-03-05 15:23:44+00:00
This submission mainly changes the enabling method of the "permanent thin controller" strategy from a feature flag switch to directly determining based on the macOS version (always enabled on macOS 13...
Impacted Classes:
remote_cocoa::ImmersiveModeControllerCocoa
remote_cocoa::features(已移除 kFullscreenPermanentThinController)
BrowserNativeWidgetWindow(ObjC 类,窗口实现相关)
+1 more
Commit:
d5bf4ba9 🔗
Time: 2025-03-04 20:08:36+00:00
This submission mainly modifies the content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm file, renaming member variables related to text replacement (such as changing _availableTextChangeCou...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
893e9d35 🔗
Time: 2025-03-04 14:55:58+00:00
This submission rolls back the previously introduced code related to “FullscreenPermanentThinController” and restores the old implementation logic. The original change was intended to address compatib...
Impacted Classes:
BrowserNativeWidgetWindow
ImmersiveModeControllerCocoa
NSTitlebarAccessoryViewController(作为属性/成员变量)
+1 more
Commit:
e6a4e771 🔗
Time: 2025-02-23 04:26:06+00:00
This submission fixes an issue in the NativeWidgetNSWindowBridge::SetParent() method where the NSWindowCollectionBehaviorTransient flag was not properly removed when setting a window as a top-level wi...
Impacted Classes:
NativeWidgetNSWindowBridge
HostingNSWindowBridge(下游继承类,间接受影响)
Commit:
af45beba 🔗
Time: 2025-02-11 21:09:01+00:00
This submission primarily refactors the implementation of the -validRequestorForSendType:returnType: method in components/remote_cocoa/app_shim/bridged_content_view.mm and content/app_shim_remote_coco...
Impacted Classes:
BridgedContentView
RenderWidgetHostViewCocoa
Centralization of Service Compatibility Patches and Refactoring of UTType Compatibility Handling
Minor
Commit:
5fe46dfa 🔗
Time: 2025-02-11 01:38:22+00:00
This submission consolidates the macOS service compatibility handling logic, previously scattered across Views and Web (primarily the clipboard/service type determination related to the NSServicesMenu...
Impacted Classes:
BridgedContentView
RenderWidgetHostViewCocoa
NSServicesMenuRequestor(协议实现相关)
+1 more
Commit:
4fa4bd07 🔗
Time: 2025-01-28 18:02:27+00:00
This submission primarily addresses the issue on Mac where invoking the “Emoji & Symbols” panel via the right-click (or control+click) menu on a text input box causes the system to select the last wor...
Impacted Classes:
RenderWidgetHostViewCocoa
Commit:
1786625b 🔗
Time: 2025-01-22 16:56:38+00:00
This submission primarily switches the implementation of popup menus from using NSPopUpButtonCell (an older macOS API with some SPI features) to supported modern APIs, and performs cleanup and refacto...
Impacted Classes:
WebMenuRunner
ContextMenuRunner
MenuControllerCocoa
+3 more